View Issue Details

IDProjectCategoryView StatusLast Update
0001592SOGoSOPEpublic2012-02-03 14:10
Reporterbuzzdee Assigned Tofrancis  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version1.3.11 
Fixed in Version1.3.12 
Summary0001592: Calling [NGImap4ServerRoot -status] with incorrect signature. Method has v8@0:4, selector has C8@0:4 -- with patch
Description

When using SOPE with OGo, then in -[NGImap4Contect refreshFolder] SOPE creates an instance variable NGImap4Folder *f and then later calls [f status].

This f at this time, when in the INBOX is of type NGImap4ServerRoot, which also implements a -status method. The -status method for NGImap4Folder returns BOOL, the one for NGImap4ServerRoot. The patch makes the return value of NGImap4ServerRoot also to return BOOL.

Additional Information

could this please be reviewed and included in the next SOPE/SOGo release.

TagsNo tags attached.

Activities

2012-01-21 13:26

 

get-rid-of-incorrect-signature-warning.diff (604 bytes)   
$OpenBSD$
--- sope-mime/NGImap4/NGImap4ServerRoot.h.orig	Sat Jan 21 19:02:55 2012
+++ sope-mime/NGImap4/NGImap4ServerRoot.h	Sat Jan 21 19:03:06 2012
@@ -94,7 +94,7 @@
 - (int)exists;
 - (int)recent;
 - (int)unseen;
-- (void)status;
+- (BOOL)status;
 - (void)select;
 - (void)expunge;
 
$OpenBSD$
--- sope-mime/NGImap4/NGImap4ServerRoot.m.orig	Sat Jan 21 19:03:17 2012
+++ sope-mime/NGImap4/NGImap4ServerRoot.m	Sat Jan 21 19:03:34 2012
@@ -329,7 +329,8 @@ static int FetchNewUnseenMessagesInSubFoldersOnDemand 
 - (void)select {
 }
 
-- (void)status {
+- (BOOL)status {
+  return YES;
 }
 
 /* actions */
francis

francis

2012-02-03 14:10

administrator   ~0003363

Fixed in revision 37cf8f46768823a23cf158ff7c9a57589c964ed7.

Issue History

Date Modified Username Field Change
2012-01-21 13:26 buzzdee New Issue
2012-01-21 13:26 buzzdee File Added: get-rid-of-incorrect-signature-warning.diff
2012-02-03 14:10 francis Note Added: 0003363
2012-02-03 14:10 francis Status new => resolved
2012-02-03 14:10 francis Fixed in Version => 1.3.12
2012-02-03 14:10 francis Resolution open => fixed
2012-02-03 14:10 francis Assigned To => francis