View Issue Details

IDProjectCategoryView StatusLast Update
0004622SOGo IntegratorWeb Calendarpublic2018-12-11 14:32
Reporterahollandmoritz Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
PlatformThunderbird 60.2.1OSWindows/MacOS 
Summary0004622: Calendar properties do not save, widnows does not close
Description

when clicking 'ok' to save changes to calendar properties nothing happens

Steps To Reproduce
  • In Thunderbird Lightning
  • right-click calendar and select properties
  • change something (e.g. color)
  • click 'OK'
  • properties window does not close, changes are not applied
Additional Information

It seems like the 'box' var is not an object, it is actually null.

I added some logging to 'properties-overlay.js' and it outputs like...

box id: sogo-0 properties-overlay.js:160:6
BOX: null properties-overlay.js:162:6
PROPNAME: calendar.sogo.0 properties-overlay.js:164:6
box id: sogo-1 properties-overlay.js:160:6
BOX: null properties-overlay.js:162:6
PROPNAME: calendar.sogo.1 properties-overlay.js:164:6
box id: sogo-2 properties-overlay.js:160:6
BOX: null properties-overlay.js:162:6

If you do a 'null' check on the 'box' the issue is fixed...but might cause other issues?

Fixed version of file (with console statments) is attached and also here: https://gist.github.com/andybeesee/9daf841ecc453831b11932f4cdb99a65#file-properties-overlay-js-L165-L167

TagsNo tags attached.

Activities

ahollandmoritz

ahollandmoritz

2018-12-11 14:13

reporter  

properties-overlay.js (7,181 bytes)
ahollandmoritz

ahollandmoritz

2018-12-11 14:32

reporter   ~0013221

note: there is a type on the attached file fixed it in the gist. Line !148 should 'if (' NOT 'ifcalendar'

Issue History

Date Modified Username Field Change
2018-12-11 14:13 ahollandmoritz New Issue
2018-12-11 14:13 ahollandmoritz File Added: properties-overlay.js
2018-12-11 14:32 ahollandmoritz Note Added: 0013221