View Issue Details

IDProjectCategoryView StatusLast Update
0003858SOGoi18npublic2016-10-21 10:58
Reporterrevanx Assigned Tofrancis  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.2.0 
Fixed in Version3.2.1 
Summary0003858: Missing values in Localizable.strings files and a typo
Description

Some of the Localizable.strings files are missing values that are called in l() function and therefore some of the text doesn't get translated when using other then English language. Please see attached patch for required changes in English.lproj files, same changes should be made for other languages too.

Also, I can't find any translation reference for values "New category" and "New label", I guess it should be added somewhere to Preferences.js and Preferences.js.map files.

Steps To Reproduce

For example:

  1. Log in to the web interface and choose other than english language
  2. Add new address book, pop up messages are in english.
TagsNo tags attached.

Activities

revanx

revanx

2016-10-21 06:20

reporter  

sogo_i18n_fix.patch (2,828 bytes)   
--- UI/Contacts/English.lproj/Localizable.strings	2016-10-03 20:18:25.000000000 +0200
+++ UI/Contacts/English.lproj/Localizable_new.strings	2016-10-21 09:36:51.808889450 +0200
@@ -128,6 +128,8 @@
 "Recipient" = "Recipient";
 "Carbon Copy" = "Carbon Copy";
 "Blind Carbon Copy" = "Blind Carbon Copy";
+"New addressbook" = "New addressbook";
+"Name of new addressbook" = "Name of new addressbook";
 "New Addressbook..." = "New Addressbook...";
 "Subscribe to an Addressbook..." = "Subscribe to an Addressbook...";
 "Remove the selected Addressbook" = "Remove the selected Addressbook";
--- UI/MailerUI/English.lproj/Localizable.strings	2016-10-03 20:18:26.000000000 +0200
+++ UI/MailerUI/English.lproj/Localizable_new.strings	2016-10-21 10:04:54.107018319 +0200
@@ -180,6 +180,7 @@
 "Copy Folder Location" = "Copy Folder Location";
 "Subscribe..." = "Subscribe...";
 "Mark Folder Read" = "Mark Folder Read";
+"New folder" = "New folder";
 "New Folder..." = "New Folder...";
 "Compact This Folder" = "Compact This Folder";
 "Search Messages..." = "Search Messages...";
@@ -260,7 +261,7 @@
 
 /* Folder operations */
 "Name" = "Name";
-"Enter the new name of your folder"
+"Enter the new name of your folder :"
  ="Enter the new name of your folder";
 "Do you really want to move this folder into the trash ?"
  = "Do you really want to move this folder into the trash ?";
@@ -355,6 +356,7 @@
 "View Mail" = "View Mail";
 "This message contains external images." = "This message contains external images.";
 "Expanded" = "Expanded";
+"Select a criteria" = "Select a criteria";
 "Add a Criteria" = "Add a Criteria";
 "More search options" = "More search options";
 "Your email has been saved" = "Your email has been saved";
--- UI/PreferencesUI/English.lproj/Localizable.strings	2016-10-03 20:18:26.000000000 +0200
+++ UI/PreferencesUI/English.lproj/Localizable_new.strings	2016-10-21 11:39:11.132662499 +0200
@@ -32,6 +32,7 @@
 "Delete" = "Delete";
 
 /* contacts categories */
+"New label" = "New label";
 "contacts_category_labels" = "Colleague, Competitor, Customer, Friend, Family, Business Partner, Provider, Press, VIP";
 
 /* vacation (auto-reply) */
@@ -180,6 +181,7 @@
 /* IMAP Accounts */
 "Mail Account" = "Mail Account";
 "New Mail Account" = "New Mail Account";
+"New account" = "New account";
 "Server Name" = "Server Name";
 "Port" = "Port";
 "Encryption" = "Encryption";
@@ -217,6 +219,7 @@
 "Add Contact Category" = "Add Contact Category";
 "Remove Contact Category" = "Remove Contact Category";
 "category_none" = "None";
+"New category" = "New category";
 "calendar_category_labels" = "Anniversary,Birthday,Business,Calls,Clients,Competition,Customer,Favorites,Follow up,Gifts,Holidays,Ideas,Meeting,Issues,Miscellaneous,Personal,Projects,Public Holiday,Status,Suppliers,Travel,Vacation";
 
 /* Default module */
sogo_i18n_fix.patch (2,828 bytes)   
revanx

revanx

2016-10-21 06:39

reporter  

sogo_i18n_fix-new.patch (2,836 bytes)   
--- UI/Contacts/English.lproj/Localizable.strings	2016-10-03 20:18:25.000000000 +0200
+++ UI/Contacts/English.lproj/Localizable_new.strings	2016-10-21 09:36:51.808889450 +0200
@@ -128,6 +128,8 @@
 "Recipient" = "Recipient";
 "Carbon Copy" = "Carbon Copy";
 "Blind Carbon Copy" = "Blind Carbon Copy";
+"New addressbook" = "New addressbook";
+"Name of new addressbook" = "Name of new addressbook";
 "New Addressbook..." = "New Addressbook...";
 "Subscribe to an Addressbook..." = "Subscribe to an Addressbook...";
 "Remove the selected Addressbook" = "Remove the selected Addressbook";
--- UI/MailerUI/English.lproj/Localizable.strings	2016-10-03 20:18:26.000000000 +0200
+++ UI/MailerUI/English.lproj/Localizable_new.strings	2016-10-21 10:04:54.107018319 +0200
@@ -180,6 +180,7 @@
 "Copy Folder Location" = "Copy Folder Location";
 "Subscribe..." = "Subscribe...";
 "Mark Folder Read" = "Mark Folder Read";
+"New folder" = "New folder";
 "New Folder..." = "New Folder...";
 "Compact This Folder" = "Compact This Folder";
 "Search Messages..." = "Search Messages...";
@@ -260,7 +261,7 @@
 
 /* Folder operations */
 "Name" = "Name";
-"Enter the new name of your folder"
+"Enter the new name of your folder :"
  ="Enter the new name of your folder";
 "Do you really want to move this folder into the trash ?"
  = "Do you really want to move this folder into the trash ?";
@@ -355,6 +356,7 @@
 "View Mail" = "View Mail";
 "This message contains external images." = "This message contains external images.";
 "Expanded" = "Expanded";
+"Select a criteria" = "Select a criteria";
 "Add a Criteria" = "Add a Criteria";
 "More search options" = "More search options";
 "Your email has been saved" = "Your email has been saved";
--- UI/PreferencesUI/English.lproj/Localizable.strings	2016-10-03 20:18:26.000000000 +0200
+++ UI/PreferencesUI/English.lproj/Localizable_new.strings	2016-10-21 12:36:50.845498917 +0200
@@ -31,6 +31,9 @@
 "Add" = "Add";
 "Delete" = "Delete";
 
+/* mail labels */
+"New label" = "New label";
+
 /* contacts categories */
 "contacts_category_labels" = "Colleague, Competitor, Customer, Friend, Family, Business Partner, Provider, Press, VIP";
 
@@ -180,6 +183,7 @@
 /* IMAP Accounts */
 "Mail Account" = "Mail Account";
 "New Mail Account" = "New Mail Account";
+"New account" = "New account";
 "Server Name" = "Server Name";
 "Port" = "Port";
 "Encryption" = "Encryption";
@@ -217,6 +221,7 @@
 "Add Contact Category" = "Add Contact Category";
 "Remove Contact Category" = "Remove Contact Category";
 "category_none" = "None";
+"New category" = "New category";
 "calendar_category_labels" = "Anniversary,Birthday,Business,Calls,Clients,Competition,Customer,Favorites,Follow up,Gifts,Holidays,Ideas,Meeting,Issues,Miscellaneous,Personal,Projects,Public Holiday,Status,Suppliers,Travel,Vacation";
 
 /* Default module */
sogo_i18n_fix-new.patch (2,836 bytes)   
revanx

revanx

2016-10-21 06:41

reporter   ~0010776

Please use sogo_i18n_fix-new.patch where I have changed location for "New label" value.

Related Changesets

sogo: master 36c5f723

2016-10-21 10:55:59

francis

Details Diff
Fix some unlocalized strings

Fixes 0003858
Affected Issues
0003858
mod - UI/PreferencesUI/English.lproj/Localizable.strings Diff File
mod - UI/Templates/MailerUI/UIxMailMainFrame.wox Diff File
mod - UI/WebServerResources/js/Contacts/AddressBooksController.js Diff File
mod - UI/WebServerResources/js/Mailer/MailboxesController.js Diff File

Issue History

Date Modified Username Field Change
2016-10-21 06:20 revanx New Issue
2016-10-21 06:20 revanx File Added: sogo_i18n_fix.patch
2016-10-21 06:39 revanx File Added: sogo_i18n_fix-new.patch
2016-10-21 06:41 revanx Note Added: 0010776
2016-10-21 10:57 francis Changeset attached => sogo master 36c5f723
2016-10-21 10:57 francis Assigned To => francis
2016-10-21 10:57 francis Resolution open => fixed
2016-10-21 10:58 francis Status new => resolved
2016-10-21 10:58 francis Fixed in Version => 3.2.1