View Issue Details

IDProjectCategoryView StatusLast Update
0002756SOGoBackend Generalpublic2014-05-22 10:24
Reporterbuzzdee Assigned Toludovic  
PriorityhighSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Platformamd64OSOpenBSDOS Version5.2
Product Version2.2.3 
Fixed in Version2.2.4 
Summary0002756: exception opening resources panel in OGo, with fix
Description

there are a few more valueForKey: -> objectForKey: transitions needed to prevent OGo from throwing an exception.

Additional Information

please review patch and apply, would be nice to have it in SOPE 2.2.4

TagsNo tags attached.

Activities

buzzdee

buzzdee

2014-05-09 03:52

reporter  

fix-ogo-resources-panel-exception.diff (1,479 bytes)   
$OpenBSD$

fix exception entering resources in ogo

--- sope-appserver/WEExtensions/WETableMatrixContent.m.orig	Fri May  9 09:21:16 2014
+++ sope-appserver/WEExtensions/WETableMatrixContent.m	Fri May  9 09:21:38 2014
@@ -83,12 +83,12 @@
     return;
   }
   
-  if ((tmp = [_ctx valueForKey:@"WETableMatrix_Query"])) {
+  if ((tmp = [_ctx objectForKey:@"WETableMatrix_Query"])) {
     [tmp addObject:[self modeKey]];
     return;
   }
   
-  if ((tmp = [_ctx valueForKey:@"WETableMatrix_Mode"]) == nil)
+  if ((tmp = [_ctx objectForKey:@"WETableMatrix_Mode"]) == nil)
     return;
 
   if (![tmp isEqualToString:[self modeKey]])
$OpenBSD$

fix exception in OGo entering resources overview

--- sope-appserver/WEExtensions/WETableMatrixLabel.m.orig	Fri May  9 09:13:53 2014
+++ sope-appserver/WEExtensions/WETableMatrixLabel.m	Fri May  9 09:14:59 2014
@@ -106,7 +106,7 @@ static NSString *retStrForInt(int i) {
   
   pos = [self->position stringValueInComponent:[_ctx component]];
   
-  if ((tmp = [_ctx valueForKey:@"WETableMatrix_Query"]) != nil) {
+  if ((tmp = [_ctx objectForKey:@"WETableMatrix_Query"]) != nil) {
     if (pos == nil)
       [self errorWithFormat:@"got no position: %@", self->position];
     else
@@ -114,7 +114,7 @@ static NSString *retStrForInt(int i) {
     return;
   }
 
-  if ((tmp = [_ctx valueForKey:@"WETableMatrix_Mode"]) == nil)
+  if ((tmp = [_ctx objectForKey:@"WETableMatrix_Mode"]) == nil)
     return;
 
   if (![tmp isEqualToString:pos])
ludovic

ludovic

2014-05-22 10:24

administrator   ~0007071

https://github.com/inverse-inc/sope/commit/6bdd62c9b2a1083dad13454d36c9179c59562664

Issue History

Date Modified Username Field Change
2014-05-09 03:49 buzzdee New Issue
2014-05-09 03:52 buzzdee File Added: fix-ogo-resources-panel-exception.diff
2014-05-22 10:24 ludovic Note Added: 0007071
2014-05-22 10:24 ludovic Status new => resolved
2014-05-22 10:24 ludovic Fixed in Version => 2.2.4
2014-05-22 10:24 ludovic Resolution open => fixed
2014-05-22 10:24 ludovic Assigned To => ludovic