View Issue Details

IDProjectCategoryView StatusLast Update
0002737SOGoBackend Generalpublic2014-05-22 10:14
Reporterbuzzdee Assigned Toludovic  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Platformamd64OSOpenBSDOS Version5.4
Product Version2.2.3 
Fixed in Version2.2.4 
Summary0002737: Exception logging in into OpenGroupware
Description

Something must have changed in SOPE after the 2.2.X upgrade, I was not able anymore to logon, due to exceptions.

The attached patch fixes the problems, its just a mechanical replacing KVO valueForKey with objectForKey in order to not trigger the exception.

Additional Information

could this please be added to upcoming 2.2.4 release

TagsNo tags attached.

Activities

buzzdee

buzzdee

2014-04-25 09:19

reporter  

fix-ogo-login.diff (1,698 bytes)   
$OpenBSD$
--- sope-appserver/WEExtensions/WEDragContainer.m.orig	Fri Apr 25 14:46:38 2014
+++ sope-appserver/WEExtensions/WEDragContainer.m	Fri Apr 25 14:47:15 2014
@@ -213,7 +213,7 @@ static BOOL debugTakeValues = NO;
   
   doDnD = [[[_ctx request] clientCapabilities] doesSupportDHTMLDragAndDrop];
   
-  if (![[_ctx valueForKey: @"WEDragContainerScriptDone"] boolValue] && doDnD) {
+  if (![[_ctx objectForKey: @"WEDragContainerScriptDone"] boolValue] && doDnD) {
     dragScript =
       @"<DIV ID=\"DragDIV\" STYLE=\"position: absolute; visibility: hidden; width: 150;\"></DIV>"
       @"<SCRIPT LANGUAGE=\"JScript\">\n"
$OpenBSD$
--- sope-appserver/WEExtensions/WEDropContainer.m.orig	Fri Apr 25 14:48:02 2014
+++ sope-appserver/WEExtensions/WEDropContainer.m	Fri Apr 25 14:48:49 2014
@@ -458,7 +458,7 @@ static NSString *dropScript = 
   
   doDnD = [[[_ctx request] clientCapabilities] doesSupportDHTMLDragAndDrop];
   
-  if (![[_ctx valueForKey:@"WEDropContainerScriptDone"] boolValue] && doDnD) {
+  if (![[_ctx objectForKey:@"WEDropContainerScriptDone"] boolValue] && doDnD) {
     [_response appendContentString:dropScript];
     
     [_ctx takeValue:[NSNumber numberWithBool:YES]
$OpenBSD$
--- sope-appserver/WEExtensions/WETabView.m.orig	Fri Apr 25 14:45:40 2014
+++ sope-appserver/WEExtensions/WETabView.m	Fri Apr 25 14:46:08 2014
@@ -821,7 +821,7 @@ static NSNumber *YesNumber;
   }
   
   doScript      = NO;  /* perform tab-clicks on browser (use javascript) */
-  tabViewCount  = [[_ctx valueForKey:@"WETabViewScriptDone"] intValue];
+  tabViewCount  = [[_ctx objectForKey:@"WETabViewScriptDone"] intValue];
   cmp           = [_ctx component];
   
   /* check for browser */
fix-ogo-login.diff (1,698 bytes)   
ludovic

ludovic

2014-05-22 10:14

administrator   ~0007069

https://github.com/inverse-inc/sope/commit/040d30bd7e1329979333822dc7a84df1efa63d9f

Issue History

Date Modified Username Field Change
2014-04-25 09:18 buzzdee New Issue
2014-04-25 09:19 buzzdee File Added: fix-ogo-login.diff
2014-05-22 10:14 ludovic Note Added: 0007069
2014-05-22 10:14 ludovic Status new => resolved
2014-05-22 10:14 ludovic Fixed in Version => 2.2.4
2014-05-22 10:14 ludovic Resolution open => fixed
2014-05-22 10:14 ludovic Assigned To => ludovic