View Issue Details

IDProjectCategoryView StatusLast Update
0002385SOGoWeb Mailpublic2013-08-07 08:52
Reporterbuzzdee Assigned To 
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Target Version2.1.0Fixed in Version2.1.0 
Summary0002385: Exception opening a given mail -- with patch
Description

opening a given mail, see attachment, ends in following exception:

EXCEPTION: <NSException: 0x1facdb06dec8> NAME:NSInvalidArgumentException REASON:GSCBufferString(instance) does not recognize appendFormat: INFO:(null)

the filename we get, doesn't seem to be a mutable string.

Attached patch fixes it for me.

This is with SOGo 2.0.7 on OpenBSD amd64.

Additional Information

gdb backtrace when exception happens:
(gdb) bt
#0 -[NSException raise] (self=0x1facdb06dec8, _cmd=0x1face0e526f0)
at NSException.m:956
0000001 0x00001face09de885 in +[NSException raise:format:] (self=0x1face0e52340,
_cmd=Variable "_cmd" is not available.
) at NSException.m:835
0000002 0x00001face0a2e3a8 in -[NSObject doesNotRecognizeSelector:] (
self=0x1face160d908, _cmd=Variable "_cmd" is not available.
) at NSObject.m:1742
0000003 0x00001face0ae644c in GSFFIInvocationCallback (cif=0x1facdb7ee900,
retp=0x7f7ffffde6e0, args=0x7f7ffffde540, user=0x1facdb06d788)
at GSFFIInvocation.m:648
0000004 0x00001face7b22c75 in ffi_closure_unix64_inner (closure=0x1facdd885010,
rvalue=0x7f7ffffde6e0, reg_args=0x7f7ffffde630,
argp=0x7f7ffffde700 "``;î¬\037") at src/x86/ffi64.c:620
0000005 0x00001face7b23514 in ffi_closure_unix64 ()
from /usr/local/lib/libffi.so.0.0
0000006 0x00001facee17fbd3 in -[UIxMailPartViewer _filenameForAttachment:] (
self=0x1facdf136d08, _cmd=Variable "_cmd" is not available.
) at UIxMailPartViewer.m:279
0000007 0x00001facee180b85 in -[UIxMailPartViewer pathToAttachment] (self=Variable "self" is not available.
)
at UIxMailPartViewer.m:299
0000008 0x00001face5bbf15d in _getComponentValue (self=0x1facdafaff08,
object=0x1facdf136d08, info=0x1facdb073400) at WOKeyPathAssociation.m:544
0000009 0x00001face5bc4c94 in -[WOKeyPathAssociation valueInComponent:] (
self=0x1facdafaff08, _cmd=Variable "_cmd" is not available.
) at WOKeyPathAssociation.m:741
---Type <return> to continue, or q <return> to quit---
0000010 0x00001face5bfe679 in -[_WOHrefHyperlink _appendHrefToResponse:inContext:]
(self=0x1facd8447908, _cmd=Variable "_cmd" is not available.
) at _WOComplexHyperlink.m:398
0000011 0x00001face5bfee37 in -[_WOComplexHyperlink appendToResponse:inContext:] (
self=0x1facd8447908, _cmd=Variable "_cmd" is not available.
) at _WOComplexHyperlink.m:271
0000012 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1face5793e08, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000013 0x00001face5be58ec in -[WOGenericContainer appendToResponse:inContext:] (
self=0x1facddee5b08, _cmd=Variable "_cmd" is not available.
) at WOGenericContainer.m:121
0000014 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1face5793d08, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000015 0x00001face5be58ec in -[WOGenericContainer appendToResponse:inContext:] (
self=0x1facddee5188, _cmd=Variable "_cmd" is not available.
) at WOGenericContainer.m:121
0000016 0x00001face5b75019 in -[WOComponent appendToResponse:inContext:] (
self=0x1facdf136d08, _cmd=0x1face5ee0500, _response=0x1face5764c08,
_ctx=0x1facdc82e408) at WOComponent.m:928
0000017 0x00001face5bde841 in -[WOComponentReference appendToResponse:inContext:] (
self=0x1facd6a93d88, _cmd=0x1face5ee0e80, _response=0x1face5764c08, _ctx=Variable "_ctx" is not available.
)
at WOComponentReference.m:164
0000018 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1facd6a93e88, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000019 0x00001face5be58ec in -[WOGenericContainer appendToResponse:inContext:] (
self=0x1facdb0bb708, _cmd=Variable "_cmd" is not available.
) at WOGenericContainer.m:121
---Type <return> to continue, or q <return> to quit---
0000020 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1facdd837d08, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000021 0x00001face5bf29ef in -[_WOComplexRepetition appendToResponse:inContext:] (
self=0x1facd6a93388, _cmd=Variable "_cmd" is not available.
) at WORepetition.m:552
0000022 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1facdd837b08, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000023 0x00001face5be58ec in -[WOGenericContainer appendToResponse:inContext:] (
self=0x1facdb0bb188, _cmd=Variable "_cmd" is not available.
) at WOGenericContainer.m:121
0000024 0x00001face5b75019 in -[WOComponent appendToResponse:inContext:] (
self=0x1face4a64008, _cmd=0x1face5ee0500, _response=0x1face5764c08,
_ctx=0x1facdc82e408) at WOComponent.m:928
0000025 0x00001face5bde841 in -[WOComponentReference appendToResponse:inContext:] (
self=0x1facdb0ba008, _cmd=0x1face5ee0e80, _response=0x1face5764c08, _ctx=Variable "_ctx" is not available.
)
at WOComponentReference.m:164
0000026 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1facdb0ba308, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000027 0x00001face5be58ec in -[WOGenericContainer appendToResponse:inContext:] (
self=0x1facdb0ba088, _cmd=Variable "_cmd" is not available.
) at WOGenericContainer.m:121
0000028 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1face16b0e08, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000029 0x00001face5b75019 in -[WOComponent appendToResponse:inContext:] (
self=0x1face22c5108, _cmd=0x1facee817aa0, _response=0x1face5764c08,
---Type <return> to continue, or q <return> to quit---
_ctx=0x1facdc82e408) at WOComponent.m:928
0000030 0x00001facee6014dc in -[UIxMailView appendToResponse:inContext:] (
self=0x1face22c5108, _cmd=Variable "_cmd" is not available.
) at UIxMailView.m:615
0000031 0x00001face5b95a39 in -[WOChildComponentReference appendToResponse:inContext:] (self=0x1face5790808, _cmd=0x1face5ee0e80, _response=0x1face5764c08,
_ctx=Variable "_ctx" is not available.
)
at WOChildComponentReference.m:181
0000032 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1face5790408, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000033 0x00001face5be58ec in -[WOGenericContainer appendToResponse:inContext:] (
self=0x1face5790f88, _cmd=Variable "_cmd" is not available.
) at WOGenericContainer.m:121
0000034 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1facdb094608, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000035 0x00001face5bdd6b4 in -[WOComponentContent appendToResponse:inContext:] (
self=Variable "self" is not available.
) at WOComponentContent.m:157
0000036 0x00001face5be58ec in -[WOGenericContainer appendToResponse:inContext:] (
self=0x1facd86d4788, _cmd=Variable "_cmd" is not available.
) at WOGenericContainer.m:121
0000037 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1facdc4fb008, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000038 0x00001face5bdfedf in -[WOConditional appendToResponse:inContext:] (
self=0x1facdded0f08, _cmd=Variable "_cmd" is not available.
) at WOConditional.m:242
0000039 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1facf17be808, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
---Type <return> to continue, or q <return> to quit---
0000040 0x00001face5bda2d6 in -[WOBody appendToResponse:inContext:] (
self=0x1facdded0c08, _cmd=Variable "_cmd" is not available.
) at WOBody.m:157
0000041 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1facf17be408, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000042 0x00001face5be58ec in -[WOGenericContainer appendToResponse:inContext:] (
self=0x1facd7f2bc88, _cmd=Variable "_cmd" is not available.
) at WOGenericContainer.m:121
0000043 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1facf17be088, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000044 0x00001face5bdfedf in -[WOConditional appendToResponse:inContext:] (
self=0x1facdb099f08, _cmd=Variable "_cmd" is not available.
) at WOConditional.m:242
0000045 0x00001face5bdf75b in -[WOCompoundElement appendToResponse:inContext:] (
self=0x1facf17bea08, _cmd=Variable "_cmd" is not available.
) at WOCompoundElement.m:245
0000046 0x00001face5b75019 in -[WOComponent appendToResponse:inContext:] (
self=0x1facdfdde608, _cmd=0x1face5e8a260, _response=0x1face5764c08,
_ctx=0x1facdc82e408) at WOComponent.m:928
0000047 0x00001face5b95a39 in -[WOChildComponentReference appendToResponse:inContext:] (self=0x1face225c588, _cmd=0x1face5ec2050, _response=0x1face5764c08,
_ctx=Variable "_ctx" is not available.
)
at WOChildComponentReference.m:181
0000048 0x00001face5b75019 in -[WOComponent appendToResponse:inContext:] (
self=0x1face079bd08, _cmd=0x1face5f10a90, _response=0x1face5764c08,
_ctx=0x1facdc82e408) at WOComponent.m:928
0000049 0x00001face5c0e12c in -[SoDefaultRenderer renderComponent:inContext:] (
---Type <return> to continue, or q <return> to quit---
self=0x1face52ab608, _cmd=Variable "_cmd" is not available.
) at SoDefaultRenderer.m:139
0000050 0x00001face5c16521 in -[SoObjectRequestHandler renderObject:inContext:] (
self=0x1facd69c6408, _cmd=Variable "_cmd" is not available.
) at SoObjectRequestHandler.m:466
0000051 0x00001face5c15bfd in -[SoObjectRequestHandler handleRequest:inContext:session:application:] (self=0x1facd69c6408, _cmd=Variable "_cmd" is not avai
lable.
) at SoObjectRequestHandler.m:616
0000052 0x00001face5ba810c in -[WORequestHandler handleRequest:] (
self=0x1facd69c6408, _cmd=0x1face5e67a20, _request=0x1facdd6cca08)
at WORequestHandler.m:237
0000053 0x00001face5b6eb8c in -[WOCoreApplication dispatchRequest:usingHandler:] (
self=0x1facd70b2508, _cmd=Variable "_cmd" is not available.
) at WOCoreApplication.m:712
0000054 0x00001faad6308182 in -[SOGo dispatchRequest:] (self=0x1facd70b2508, _cmd=Variable "_cmd" is not available.
)
at SOGo.m:453
0000055 0x00001face5c0501d in -[WOHttpTransaction _run] (self=0x1facdea74b08, _cmd=Variable "_cmd" is not available.

) at WOHttpTransaction.m:592
0000056 0x00001face5c04ef8 in -[WOHttpTransaction run] (self=Variable "self" is not available.
)
at WOHttpTransaction.m:645
0000057 0x00001face5c026c9 in -[WOHttpAdaptor runConnection:] (
self=0x1facdd6cea08, _cmd=Variable "_cmd" is not available.
) at WOHttpAdaptor.m:367
0000058 0x00001face5c024ee in -[WOHttpAdaptor _handleAcceptedConnection:] (
self=0x1facdd6cea08, _cmd=Variable "_cmd" is not available.
) at WOHttpAdaptor.m:401
0000059 0x00001face5c02150 in -[WOHttpAdaptor _handleConnection:] (
self=0x1facdd6cea08, _cmd=0x1face0e526f0, connection=0x1facdea74a08)
---Type <return> to continue, or q <return> to quit---
at WOHttpAdaptor.m:460
0000060 0x00001face5c0399c in -[WOHttpAdaptor acceptConnection:] (self=Variable "self" is not available.
)
at WOHttpAdaptor.m:521
0000061 0x00001face0a1c5f9 in -[NSNotificationCenter _postAndRelease:] (
self=0x1facda698448, _cmd=Variable "_cmd" is not available.
) at NSNotificationCenter.m:1223
0000062 0x00001face0b20a21 in -[GSRunLoopCtxt pollUntil:within:] (
self=0x1facdd6e4608, _cmd=Variable "_cmd" is not available.
) at GSRunLoopCtxt.m:629
0000063 0x00001face0a6642c in -[NSRunLoop acceptInputForMode:beforeDate:] (
self=0x1face3342208, _cmd=0x1face0e96a40, mode=0x1face0e96ae0, limit_date=Variable "limit_date" is not available.
)
at NSRunLoop.m:1195
0000064 0x00001face0a6482b in -[NSRunLoop runMode:beforeDate:] (
self=0x1face3342208, _cmd=0x1face5e67910, mode=0x1face0e96ae0,
date=0x1facd7e722c8) at NSRunLoop.m:1263
0000065 0x00001face5b6f417 in -[WOCoreApplication run] (self=Variable "self" is not available.
)
at WOCoreApplication.m:584
0000066 0x00001faad630757f in -[SOGo run] (self=0x1facd70b2508, _cmd=Variable "_cmd" is not available.
)
at SOGo.m:277
0000067 0x00001face5b95795 in WOApplicationMain (_appClassName=0x1faad650c1a0,
argc=Variable "argc" is not available.
) at WOApplicationMain.m:42
0000068 0x00001face5bb1cf4 in WOWatchDogApplicationMain (appName=0x1faad650c1a0,
argc=7, argv=0x7f7ffffe0570) at WOWatchDogApplicationMain.m:1031
0000069 0x00001faad63068f5 in gnustep_base_user_main (argc=7, argv=0x7f7ffffe0570,
---Type <return> to continue, or q <return> to quit---
env=Variable "env" is not available.
) at sogod.m:53
0000070 0x00001faad6306631 in ___start () from /usr/local/sbin/sogod
0000071 0x0000000000000007 in ?? ()
0000072 0x00007f7ffffe06a0 in ?? ()
0000073 0x00007f7ffffe06b6 in ?? ()
0000074 0x00007f7ffffe06c5 in ?? ()
0000075 0x00007f7ffffe06c8 in ?? ()
0000076 0x00007f7ffffe06d3 in ?? ()
0000077 0x00007f7ffffe06d5 in ?? ()
0000078 0x00007f7ffffe06e1 in ?? ()
0000079 0x0000000000000000 in ?? ()
(gdb)
(gdb) frame 6
0000006 0x00001facee17fbd3 in -[UIxMailPartViewer _filenameForAttachment:] (
self=0x1facdf136d08, _cmd=Variable "_cmd" is not available.
) at UIxMailPartViewer.m:279
279 [filename appendFormat: @".%@", extension];
(gdb) list
274
275 if (![[filename pathExtension] length])
276 {
277 extension = [self preferredPathExtension];
278 if (extension)
279 [filename appendFormat: @".%@", extension];
280 }
281
282 return [filename stringByEscapingURL];
283 }

TagsNo tags attached.

Activities

2013-08-01 08:56

 

patch-UI_MailPartViewers_UIxMailPartViewer_m (410 bytes)   
$OpenBSD$
--- UI/MailPartViewers/UIxMailPartViewer.m.orig	Thu Aug  1 12:17:08 2013
+++ UI/MailPartViewers/UIxMailPartViewer.m	Thu Aug  1 14:41:07 2013
@@ -266,7 +266,7 @@
   NSMutableString *filename;
   NSString *extension;
 
-  filename = [self filename];
+  filename = [[self filename] mutableCopy];
   if (![filename length])
     [filename appendFormat: @"%@-%@",
 	      [self labelForKey: @"Untitled"],

2013-08-01 09:02

 

16624.eml (105,439 bytes)
ludovic

ludovic

2013-08-07 08:52

administrator   ~0005792

I've pushed a better fix: https://github.com/inverse-inc/sogo/commit/7b90b892fc0a1a2f333a82c49759812725556ffb

Issue History

Date Modified Username Field Change
2013-08-01 08:56 buzzdee New Issue
2013-08-01 08:56 buzzdee File Added: patch-UI_MailPartViewers_UIxMailPartViewer_m
2013-08-01 09:02 buzzdee File Added: 16624.eml
2013-08-07 08:52 ludovic Target Version => 2.1.0
2013-08-07 08:52 ludovic Note Added: 0005792
2013-08-07 08:52 ludovic Status new => closed
2013-08-07 08:52 ludovic Resolution open => fixed
2013-08-07 08:52 ludovic Fixed in Version => 2.1.0