Dependency Graph

Dependency Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

IDProjectCategoryView StatusLast Update
0003306SOGowith SOGopublic2015-09-03 14:17
Reporterams077 Assigned Tofrancis  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platform[Server] LinuxOSDebianOS Version7 (Wheezy)
Product Version2.3.1 
Target Version2.3.2Fixed in Version2.3.2 
Summary0003306: Comma in display name of meeting organiser not handled correctly.
Description

When accepting an invite from someone with a comma in their displaname, SOGo messes up the 'to' header in the acceptance notification email.

Steps To Reproduce
  1. Receive an event invite from someone with a comma in their displayname. E.g.
    """
    ORGANIZER;RSVP=TRUE;CN="Sheppard, Alex";PARTSTAT=ACCEPTED;ROLE=CHAIR:mailto:alex@das-computer.co.uk
    """

  2. Accept the invite

  3. SOGo messes up the 'to' header when trying to send the invite acceptance notification. E.g.
    """
    to: Sheppard,
    "Alex" <alex@das-computer.co.uk>
    """

Additional Information

It looks like SOGo has a lot of problems with commas in displaynames. These bugs may be related?

http://www.sogo.nu/bugs/view.php?id=3301
http://www.sogo.nu/bugs/view.php?id=3298
http://www.sogo.nu/bugs/view.php?id=3296

TagsNo tags attached.

Relationships

duplicate of 0003301 resolvedfrancis If "displayname" in LDAP has a comma between firstname and lastname sender address in the webinterface is wrong 

Activities

tfu

tfu

2015-08-13 16:31

reporter  

mailAddrWithComma.diff (992 bytes)   
diff --git a/sope-mime/NGMail/NGMailAddressParser.m b/sope-mime/NGMail/NGMailAddressParser.m
index 4b4e02d..1413e63 100644
--- a/sope-mime/NGMail/NGMailAddressParser.m
+++ b/sope-mime/NGMail/NGMailAddressParser.m
@@ -378,7 +378,7 @@ static inline id parseDomainLiteral(NGMailAddressParser *self, BOOL _guessMode)
   NSMutableString* remainder;
   NSMutableArray* addressList;
   NSString *address, *displayName;
-  NSRange r, c;
+  NSRange r, c, a;
   NSCharacterSet *whitespace;
 
   NSUInteger addrStart, addrEnd, commaPos;
@@ -406,7 +406,8 @@ static inline id parseDomainLiteral(NGMailAddressParser *self, BOOL _guessMode)
     r = [remainder rangeOfString: @"<"];
     addrStart = r.location;
 
-    c = [remainder rangeOfString: @","];
+    a = [remainder rangeOfString: @"@"];
+    c = [remainder rangeOfString: @"," options:0 range:NSMakeRange(a.location+1, [remainder length]-a.location-1)];
     commaPos = c.location;
 
     if ((addrStart == NSNotFound) || (commaPos < addrStart))
mailAddrWithComma.diff (992 bytes)   
tfu

tfu

2015-08-13 16:31

reporter   ~0008820

Attach SOPE patch should fix the described problem.

sogobug

sogobug

2015-08-24 11:12

reporter   ~0008851

This patch fixed http://www.sogo.nu/bugs/view.php?id=3301 too. This is quite an annoying bug since the reply-to from the mail is also wrong. The answers to these mails are sent to invalid addresses then.

Please fix this in a nightly build or bugfix release. There was a similar bug before, see http://www.sogo.nu/bugs/view.php?id=2267

francis

francis

2015-09-03 14:17

administrator   ~0008888

Last edited: 2015-09-03 14:17

View 2 revisions

Thanks tfu!

https://github.com/inverse-inc/sope/commit/7dcb6a244b5cdf5812541d5ddba9c63994ec7eb7

Issue History

Date Modified Username Field Change
2015-08-12 12:05 ams077 New Issue
2015-08-13 16:31 tfu File Added: mailAddrWithComma.diff
2015-08-13 16:31 tfu Note Added: 0008820
2015-08-24 11:12 sogobug Note Added: 0008851
2015-08-25 15:55 francis Target Version => 2.3.2
2015-08-27 04:37 Christian Mack Relationship added duplicate of 0003301
2015-09-03 14:17 francis Note Added: 0008888
2015-09-03 14:17 francis Status new => resolved
2015-09-03 14:17 francis Fixed in Version => 2.3.2
2015-09-03 14:17 francis Resolution open => fixed
2015-09-03 14:17 francis Assigned To => francis
2015-09-03 14:17 francis Note Edited: 0008888 View Revisions