|
|
Do you get old emails when you do some changes on them? >mark them as unread/read |
|
|
|
I set up a fresh profile. It synced all emails. |
|
|
|
Without the steps to reproduce I just can do some guessing.
I assume that it happens that outlook send a sync request with getChanges=fales and if that is the first call after a long "break" it currently set the syncKey to the latest value and this ignores all previous emails on the next sync request.
The attached patch should fix that. Due to lake of time it is not tested. Maybe somebody can do some testing with it and provide feedback. |
|
tfu
2014-10-31 14:32
reporter
|
0001-getChanges-syncKey.patch (1,192 bytes)
From 134bc3fc24cd43279e8ab48ab018896a659beff3 Mon Sep 17 00:00:00 2001
From: root <root@poldi.hopto.org>
Date: Fri, 31 Oct 2014 15:11:53 +0100
Subject: [PATCH] getChanges - syncKey
---
ActiveSync/SOGoActiveSyncDispatcher+Sync.m | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ActiveSync/SOGoActiveSyncDispatcher+Sync.m b/ActiveSync/SOGoActiveSyncDispatcher+Sync.m
index 86a2e5c..0b90a2e 100644
--- a/ActiveSync/SOGoActiveSyncDispatcher+Sync.m
+++ b/ActiveSync/SOGoActiveSyncDispatcher+Sync.m
@@ -1071,7 +1071,10 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
else
nameInCache = [collection nameInContainer];
- if (![[self _folderMetadataForKey: nameInCache] objectForKey: @"MoreAvailable"])
+ // use the SyncKey saved by processSyncGetChanges - if processSyncGetChanges is not called (because of getChanges=false) SyncKey has the value of the previous sync.
+ davCollectionTag = [[self _folderMetadataForKey: nameInCache] objectForKey: @"SyncKey"];
+
+ if (davCollectionTag)
davCollectionTag = [collection davCollectionTag];
}
--
1.7.10.4
|
|
|
|
I found some time to do some tests... There is some more work needed to fix the issue. Although the patch is working for email folders there will be an issue that dup events will be created on the client sending new events.
-> syncCache is needed for calendar and contacts folder. |
|
|
|
Can you specify dup events part?
Does it mean that duplicate events are created when client creates new event? |
|
|
|
Yes, this can happen with the patch. If there is no change on the server the event will sent to the client as an addition on each sync since the serverKey doesn't change. -> more work is needed to fix this... |
|
|
|
Fixed with:
https://github.com/inverse-inc/sogo/commit/b3cd609ae76414237db120fd76545afe11f6346b
and:
https://github.com/inverse-inc/sogo/commit/3872341a85c4e54a5671bde5e414c58c1ebca19e
Please try the upcoming nightly builds. |
|
